Question

Could someone possibly evaluate my code for PSet3? I'm somewhat sure they work, but it would be nice if someone could point out any obvious flaws or improvements that could be made (efficiency, simpler coding, etc...). Thanks.
http://dpaste.com/hold/541009/

Answer 1

Hi Macomac, for subStringMatchExactlyOneSub your function returns an empty tuple.
target1 = 'atgacatgcacaagtatgcat'
key11 = 'atg'

Your nested for loops makes repeated calls to subStringMatchExact, you would be better off saving the result into a temporary variable, and just access that variable instead of making the function call.

line 32 and 33 can be replaced with 'if n+length+1 in secondMatch :'. the in function pretty much does the looping and searching that you're doing with the inner for loop.

Answer 2

Thanks a lot. Your advice is very appreciated, and it worked great. The repetition problem is fixed.

Answer 3

Macomac, you can post links and attach files in replies as well as questions. If you forget to add a link or file to a post, which I do all the time, just add another post. You don't need to start a new thread.