Question

You are doing a code review. A programmer has written the following function, which uses unnecessary temporary objects in at least three places. How many can you identify, and how should the programmer fix them?

string FindAddr( list emps, string name ) { for( list::iterator i = emps.begin(); i != emps.end(); i++ ) { if( *i == name ) { return i->addr; } } return ""; }

Answer 1

Maybe try it on StackOverFlow

Answer 2

Software Engineering exam?

Answer 3

No, not exam.....just a puzzle.............:D
Try it.....:D

Answer 4

@Gary: Its a puzzle dear...:D

Answer 5

it is a diffficult 1

Answer 6

No, not at all. It is fairly easy, if basic programming concepts are clear.......:D

Answer 7

I'll just try this out, delete random stuff, and see if it still works :-D

Answer 8

or maybe this is some huge trick question that can be solved with some nice library function?

Answer 9

it is very very easy dude......:D
There is no need to try it using a compiler + IDE...........:P

Answer 10

or is it passing by value things that is better to pass by referece like some objects?

Answer 11

yeah 'unnecessary temporary objects' instead of the whole list just pass an address

Answer 12

and make it readonly

Answer 13

Behavior should not be changed!!!!!!!!!!!

Answer 14

yeah why would behavior change if you pass a simple readonlyreference?

Answer 15

you are close to answer...go ahead...........:D

Answer 16

return "";

I think instead of doing this, just use addr

Answer 17

wow, something else?

Answer 18

I think the rest are more subtle and relate to C++ operations on objects making temporary stuff.

Answer 19

Compared to C, C++ is more complex :-D

Answer 20

gary of course it's difficult if you don't know C++ language

Answer 21

I'm sure this stuff is elementary stuff out of a good C++ textbook, which I will read once I'm done with learning C.

Answer 22

This stuff is not from a textbook!!