Question

http://ideone.com/9LMM5

So I have no more memory leak problems and bad calls to free(), but my code still looks terrible. How can I improve my code?

Answer 1

thats glad to hear that your code is bugs free....yu can improve it by intendation ,i mean give spaces at appropriate modules and index the paranthesis and so on......do it repeatedly to make yur code look like me..:P

Answer 2

and you also should write more comments :D

Answer 3

I thought my code was practically self-documenting :-D All it does is break the integer apart, match each piece into an english word (string), and then contatenate all the strings together. How complex could it be?.

Answer 4

You're right though... I shaved away all the comments while I was debugging it....

Now I will make it work for decimals... (float 14) and then arbitrary precision numbers!

Answer 5

I think you can do this thing in Java way easier. :-P

Answer 6

So, to be honest, it is possible to write code that is ostensibly self-documenting, at least most of the time. It takes two things:

(1) Very clear (tradeoff: potentially long) function/method names. To see this taken to the extreme, look at the Objective-C Cocoa APIs. Some of these are definitely excessive (e.g., [array itemAtIndex:0]).
(2) Breaking things down into functions as much as possible. This is harder in C because you have to do some backflips to make sure the code isn't super-slow by consequence and still stays relatively clear (pointers start flying really fast), but it's still doable. But pretty much every distinct block of code can get its own function if you want to go this way.

This way, you end up with parent functions that just call a set of other functions in a very narrative fashion.