Question

What's wrong with my code for finding the highest integer in a given data? (C Programming)

Answer 1

```
#include <stdio.h>
#include <conio.h>

main()
{
int numData, cntr, max;
int data[10];

printf("How many numbers? ");
scanf("%d", &numData);

max = data[0];

for (cntr = 0; cntr < numData; cntr++)
{
printf("Data #%d > ", cntr + 1);
scanf("%d", &data[cntr]);
}

for (cntr = 0; cntr < numData; cntr++)
{
if (data[cntr] < data[cntr + 1])
{
max = data[cntr + 1];
data[cntr + 1] = data[cntr];
if (numData > cntr + 1)
continue;
else
break;
}
else
{
max = data[cntr];
if (numData > cntr + 1)
continue;
else
break;
}
}

printf("The highest number is %d", max);
getch();

}
```

Answer 2

well first it says "getch" I believe you meant to say fetch();?

Answer 3

Also you have the same for loop twice, I would combine then if possible.

Answer 4

actually getch() doesn't matter....it's just a function so that the program doesn't exit immediately

Answer 5

also...the two loops have different functions....

Answer 6

Yeah I see that now with the loops... I had written a program like this awhile ago... But In Java there's a comparator that does all the work for you so :P.

Answer 7

I'll quickly try to code it and see if my code can show any errors.

Answer 8

Does the first for loop read in the data?

Answer 9

why are you doing such a difficult programming?

Answer 10

the program you are writing is for sorting .

Answer 11

let me help you put to find out the maximum number.
tak 1 variable max.
put the condition in 2nd for loop that if max > data[cntr] then max=data[cntr].

you will get the answer.

Answer 12

Enjoy C coding.

Answer 13

@rambo2210 so my 2nd loop is the mistake?

Answer 14

yeap.

Answer 15

let me help you put to find out the maximum number.
tak 1 variable max.
put the condition in 2nd for loop that if max > data[cntr] then max=data[cntr].

you will get the answer.

Answer 16

follow those steps you will geth answer.

Answer 17

your 2nd for loop must look like dis:-
for (cntr = 0; cntr < numData; cntr++)
{
if(max < data[cntr])
{
max=data[cntr];
}
}

Answer 18

no need to reloop it?

Answer 19

this doesn't work

```
#include <stdio.h>
#include <conio.h>

main()
{
int numData, cntr, max;
int data[10];

printf("How many numbers? ");
scanf("%d", &numData);

max = data[0];

for (cntr = 0; cntr < numData; cntr++)
{
printf("Data #%d > ", cntr + 1);
scanf("%d", &data[cntr]);
}

for (cntr = 1; cntr < numData; cntr++)
{
if (max < data[cntr])
{
max = data[cntr];
if (numData > cntr)
continue;
else
break;
}

}

printf("The highest number is %d", max);
getch();

}
```

Answer 20

if (max < data[cntr])
{
max = data[cntr];
if (numData > cntr)
continue;
else
break;

change above loop to below loop:-
if(max<data[cntr])
{
max = data[cntr];
}
}//end od for loop

Answer 21

but how will it check the other numbers?

Answer 22

it will check you just try.
once you will get output.
then I will explain you.

Answer 23

still doesn't work

```
#include <stdio.h>
#include <conio.h>

main()
{
int numData, cntr, max;
int data[10];

printf("How many numbers? ");
scanf("%d", &numData);

max = data[0];

for (cntr = 0; cntr < numData; cntr++)
{
printf("Data #%d > ", cntr + 1);
scanf("%d", &data[cntr]);
}

for (cntr = 1; cntr < numData; cntr++)
{
if (max < data[cntr])
max = data[cntr];


}

printf("The highest number is %d", max);
getch();

}
```

Answer 24

even if i change cntr to cntr = 0...still doesn't work

Answer 25

initialize max = 0.
and remove max = data[0];

Answer 26

it worked...

i get why the if statement is that way...but i don't get why initialize max as 0

Answer 27

you were assigning the max value before getting the value from user. so It will be some garbage value which might be greater than all of the number you have entered.

Answer 28

well my plan was just to assign the first variable as temporary maximum then compare it with the others

Answer 29

then you should put that after following loop.
for (cntr = 0; cntr < numData; cntr++)
{
printf("Data #%d > ", cntr + 1);
scanf("%d", &data[cntr]);
}
max = data[0];
for (cntr = 1; cntr < numData; cntr++)
...

an so on.

try this it will work for sure.

Answer 30

Got the answer.
or still confused?

Answer 31

yes that helps

Answer 32

SO If you have any question about C programming.please contact me.I can surely help you out.