Question

Whats wrong in this program in C++ to print the fibonacci series ?

#include #include void main() {clrscr(); int x=0,y=1,z,n=1; while(n<=20) {z=x+y; cout< 11 years ago

Answer 1

In c++ you should only append .h for c headers not cpp headers.
```
#include<iostream>
```

main() is of type integer not void.
```
int main()
```

cout is a function in std.
```
std::cout
```

you set both x and y to same value in this step x=z,y=x; this is wrong.

Answer 2

Can you please write a corrected version ? Of the last part ? I'll understand better then :)

Answer 3

how does the << operator work?

Answer 4

That is a default for output

Answer 5

oh, so it outputs z each iteration?

Answer 6

Yup

Answer 7

if the y=x happens after the x = z, then y and x end up holding the same term number, instead of the highest 2 term numbers - then adding up x and y next iteration wouldn't give you the next term in the fibonacci sequence, just would equal 2*z.

Answer 8

Oh Oh ! So if I write y=x first and then x=z ? Will that be okay ?

Answer 9

should be in terms of algorithm :) though idk c++ syntax

Answer 10

Let me compile it that way.

Answer 11

IT WORKED

Answer 12

Thank you so much both of you :)

Answer 13

yw! does it make sense?

Answer 14

Yep it does :) Now that you have explained it, yes it does :)

Answer 15

ya, say you are holding y = 5 and x = 8, when you do z = x + z;
z = 13, the next term in the sequence-- now you need x and y to reset to the term 13, and 8, so that when you add them next time, it will = the next term in the sequence.

y = x will give y the term before 13 &
x = z will give x the new highest term value of 13,

but doing x = z first, will indeed set it equal to 13, but when you do
y = x, you also get 13, and the addition of x & y next iteration will just be 13 * 2

ik I already said this, but just thought this looks much neater w/ examples & sitch.

Answer 16

And looks like Lyrae has some helpful tips for proper syntax ^^

Answer 17

Even if the program runs without making those changes, I'm sure there is good reason for them.

Answer 18

http://ideone.com/1TwNIn

Answer 19

Thanks a lot :) @Lyrae