Question

what's wrong with this code

Answer 1

```
#include <stdio.h>
#include <conio.h>

main()
{
int numData, cntr;
int data[10];

printf("How many numbers? ");
scanf("%d", &numData);

for (cntr = 0; cntr < numData; cntr++)
{
printf("Data %d> ", cntr + 1);
scanf("%d", &data[cntr]);
}

for (cntr = 0; cntr < numData; cntr++)
{
for (cntr = 0; cntr < numData; cntr++)
{
if (data[cntr] > data[cntr + 1])
{
data[cntr] = data[cntr + 1];
}
else
break;
}
}

for (cntr = 0; cntr < numData; cntr++)
{
printf("%d ", data[cntr]);
}



getch();
}

```

Answer 2

it's purpose is supposed to arrange a given data by increasing order

Answer 3

@rambo2210 think you can solve this?

Answer 4

yeap sure.
wait for a while.

Answer 5

sure

Answer 6

yeap got the solution .but this time you should help youself.

Answer 7

first of all you have to use 2 different variable in for loops.

Answer 8

what do you mean? cntr and counter? like that?

Answer 9

yeap.
because if you use the same then outer loop will be execute only once.
check properly.

Answer 10

hmm...so that's why they do that in matrices

Answer 11

yeap.
not only that you are not done yet.
check out.

Answer 12

yes i see...it just displayed exact order i input

Answer 13

let me try thinking how to make it arrange

Answer 14

yeap.
take your time.
and still dont get.
than contact me.
I have whole code written

Answer 15

hmm if data [cntr] < data[cntr + 1] then i should compare data[cntr + 1] to the others right?

Answer 16

yeap.

Answer 17

hmm i can't seem to see how to do that

Answer 18

you code will work perfect if you provide the numbers in decreasing order.
try this,

Answer 19

provide the numbers in decreasing order?

Answer 20

sry sry ..still it wont work.

Answer 21

so what do you want to know?

Answer 22

wait... i think i have an idea

Answer 23

thats gr8.

Answer 24

this is very complicated

Answer 25

you have to take 1 temporary variable.

Answer 26

post here your modified code.

Answer 27

i haven't done anything

Answer 28

should post my code or you want to try.?

Answer 29

Hello?????? got the answer.?

Answer 30

still thinking

Answer 31

OK.

Answer 32

i give up

Answer 33

oh..sad.//

Answer 34

for (cntr1 = 0; cntr1 < numData-1; cntr1++)
{
for (cntr = 0; cntr < numData; cntr++)
{
if (data[cntr] > data[cntr + 1])
{
temp=data[cntr];
data[cntr] = data[cntr + 1];
data[cntr +1] =temp;
}
}
}

Answer 35

so what did you do here?

Answer 36

first I will compare:- if(data[cntr] > data[cntr + 1]))
if hte condition is true:- I will swap that 2 number. thats it.

Answer 37

why not put temp = data[cntr] outside the if?

Answer 38

No you should copy to temp only if the condition of if satisfied.

Answer 39

hmm i'll try

Answer 40

it doesn't seem to work

Answer 41

post you code.

Answer 42

ah found how to fix it

Answer 43

still I have somthing to explain you once you are done. please post you code here.

Answer 44

#include <stdio.h>
#include <conio.h>

main()
{
int numData, cntr, counter, temp;
int data[10];

printf("How many numbers? ");
scanf("%d", &numData);

for (cntr = 0; cntr < numData; cntr++)
{
printf("Data %d> ", cntr + 1);
scanf("%d", &data[cntr]);
}

for (cntr = 0; cntr < numData; cntr++)
for (counter = 0; counter < numData; counter++)
if (data[counter] > data[counter + 1])
{
temp = data[counter];
data[counter] = data[counter + 1];
data[counter + 1] = temp;
}

for (cntr = 0; cntr < numData; cntr++)
{
printf("%d ", data[cntr]);
}



getch();
}

Answer 45

i really don;t get why put temp = data[counter] in the if statement though

Answer 46

So where do you want to put it?

Answer 47

outside the for loop

Answer 48

as a good developer you should consider the execution time also.
outer for loop need to run only as follow:
for (cntr = 0; cntr < numData-1; cntr++)

Answer 49

ah yes...putting it before the if statement works

Answer 50

i meant if statement..not the for loop

Answer 51

It will work but it will increase the execution time,

Answer 52

why so? it's still just executed once...

Answer 53

by the way...is it really necessary to always assign variables?

Answer 54

it will copy data[counter] to temp everytime which is not required.
you have to use temp only to swap the two number.

Answer 55

hmm..that makes sense

Answer 56

so it's necessary to assign variables always?

Answer 57

what? I did not get you. example please.

Answer 58

when you assigned data[cntr] to temp

Answer 59

because simply doing data[cntr] = data[cntr + 1] doesn't work

Answer 60

if you do data[cntr] = data[cntr + 1] you will loose the value of data[cntr] which you need.